RFR 4358774: Add null InputStream and OutputStream
Roger.Riggs at Oracle.com
Thu Dec 7 22:04:33 UTC 2017
For checking indices, I think you should leverage the work done for
as optimized for this purpose in 8135248. That was extensively designed
and reviewed for optimal performance.
On 12/7/2017 2:27 PM, Brian Burkhalter wrote:
> Updated patch:
> On Dec 7, 2017, at 6:08 AM, Alan Bateman <Alan.Bateman at oracle.com
> <mailto:Alan.Bateman at oracle.com>> wrote:
>> If nothing else, a private ensureOpen method would make it easier to
>> read so that the "if (closed) throw ..." isn't needed in every method.
> On Dec 6, 2017, at 7:03 PM, Vitaly Davidovich <vitalyd at gmail.com
> <mailto:vitalyd at gmail.com>> wrote:
>> From a performance angle, I'd be more concerned with the calls to
>> Objects.xyz() methods there. Unless something has changed in the JIT
>> recently, those are susceptible to profile pollution and can cause
>> missed optimizations. I'd inline those methods manually to give
>> these methods their own profiles.
More information about the core-libs-dev