RFR (JDK10) 8183743: Umbrella: add overloads that take a Charset parameter

Joe Wang huizhe.wang at oracle.com
Sat Dec 9 00:29:57 UTC 2017

Thanks Roger, Alan for the comments!

I've updated the webrev accordingly. Here's the current webrev:


On 12/4/17, 7:52 PM, Joe Wang wrote:
> On 12/3/17, 11:34 AM, Alan Bateman wrote:
>> On 01/12/2017 20:35, Joe Wang wrote:
>>> :
>>>> I think URLDecoder.decode methods should have @throws 
>>>> IllegalArgumentException. I realize it's implementation specific as 
>>>> to whether IAE is thrown with bad input but given that the RI does 
>>>> throw IAE then consumers of the API should be prepared for it. The 
>>>> @implNote can stay and probably should be copied into the legacy 
>>>> decode method too.
>>> I added @throws IAE. On a 2nd thought, would that give no 
>>> flexibility to alternative impls as the general (class) spec had 
>>> given? With this addition, it becomes a requirement.
>> If the @throws description starts with "if the implementation ..." 
>> then it should be clear that it is optional.
> Thanks Alan. I made the change accordingly.
> http://cr.openjdk.java.net/~joehw/jdk10/8183743/webrev/index.html
> -Joe
>> -Alan

More information about the core-libs-dev mailing list