[10] RFR: 8193507: [REDO] Startup regression due to JDK-8185582

Xueming Shen xueming.shen at oracle.com
Sat Dec 16 00:46:00 UTC 2017

On 12/15/17, 3:43 PM, Peter Levart wrote:
> Hi Claes,
> I see this is already pushed. I don't have any additional comments, 
> but just want to know what was wrong with old code. You say that you 
> used non-static inner classes. I don't see that in old code. All the 
> lambdas you replaced with nested static classes should have already 
> captured just local variables. I must be missing something and I would 
> really like to know what.


Since that code triggered all zip/cleaner regression tests failed. I 
rollback-ed that
fix overnight to make our overnight tests happy. So what in the webrev 
is against my
original code.

Here is my webrev that undo-ed the non-static inner classes.



> Regards, Peter
> Claes Redestad je 14. 12. 2017 ob 12:07 napisal:
>> Hi,
>> my previous fix failed due to use of non-static inner classes which 
>> kept the cleanable objects around. Also, Sherman suggested a more 
>> thorough fix to Inflater/Deflater after I had already pushed.
>> Webrev: http://cr.openjdk.java.net/~redestad/8193507/open.00/
>> Verified all java/util/zip tests pass this time.
>> /Claes

More information about the core-libs-dev mailing list