RFR of 8146656: Wrong Months Array for DateFormatSymbols
rachna.goel at oracle.com
Tue Dec 19 09:13:55 UTC 2017
Thanks for the review.
Reason I added @implNote is that it's the case for the default
implementation. Not added as a part of spec, as some implementation can
just return 12 element array for same methods through the
On 19/12/17 2:07 PM, joe darcy wrote:
> Hello Rachna,
> On 12/18/2017 10:35 PM, Rachna Goel wrote:
>> Kindly review API Doc fix for java.text.DateFormatSymbols.
>> JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656
>> Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev/
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8191414
> An addendum to my CSR review. The newly added text should be
> normative, not just informative. That is, the text should officially
> be part of the specification of the class.
> If you do not want the 13 elements behavior to be required of a
> subclass, change the @implNote into an @implSpec. If you want 13
> elements to be required of subclasses too, replace @implNote with a
> paragraph begin. (For more guidance on @impNote vs @implspec, etc. see
> The CSR should be updated with the amended API change.
More information about the core-libs-dev