RFR(M) : 8181335 : remove packageless CompilerUtils

Alan Bateman Alan.Bateman at oracle.com
Tue Jun 6 10:59:19 UTC 2017

On 06/06/2017 07:15, Igor Ignatyev wrote:
>> On Jun 5, 2017, at 10:50 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On 06/06/2017 06:10, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev/8181335/webrev.00/index.html
>> I added this so-called "packageless" CompilerUtils some time ago. I see the version copied into the top-level repo is an older version and doesn't specify UOE or handle the JRE case. Can you update the version in the top repo as part of this so that they are the same?
> I have updated it, just forgot to include into webrev, here is the diff:
The javadoc still seems out of date - you can you just copy the version 
in the jdk repo to the top repo and add the package declaration?

> :
>> Finally, one thing to keep in mind is that you are changing tests and test infrastructure that is still changing in jdk9/dev. We have one (we hope) final module system refresh coming that changes several of the tests that you are changing. This might be a bit annoying for whoever sync's up jdk10/jdk10 from jdk9/jdk9 in a few weeks time.
> how many tests will be changed by this module system refresh?
The SL tests have been significantly refactored in the jake forest. 
There are also changes to several module tests, some new tests too. Most 
of these changes should be trivial to merge but there will be at least 
some updates needed to get the new/changed tests working again once they 
meet up with your changes.


More information about the core-libs-dev mailing list