RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows
erik.joelsson at oracle.com
Thu Jun 8 06:23:36 UTC 2017
Build changes look good with Mandy's correction. I would also like a
comment sentence explaining the reason for EXTRA_JAVA_ARGS in
LauncherCommon.gmk. Otherwise we risk cleaning this away in the future.
On 2017-06-08 03:12, Mandy Chung wrote:
>> On Jun 7, 2017, at 2:58 PM, Kumar Srinivasan <kumar.x.srinivasan at oracle.com> wrote:
>> Please review the changes to fix JDK-8180334, essentially -DJAVA_ARGS exceeds
>> a Visual Studio C++ compiler limit, and this fix provides a way to specify
>> very long string literals, by the build system.
>> This also includes some minor and subtle simplifications and cleanups wrt.
>> the JAVA_ARGS and its handling.
>> Webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.00
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8180334
> This is a reasonable short-term solution. As we discussed, we should
> look into extending jlink to create the native launcher using @argfile
> in a future release.
> +# EXTRA_JAVA_ARGS Processed into a -DEXTRA_JAVA_ARGS and is prependedi
> typo: s/prependedi/prepended
> It may help to detect if main_jargc == 0 but extra_jargc > 0 and exit with an error in case any bug in creating such a launcher.
More information about the core-libs-dev