RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows
kumar.x.srinivasan at oracle.com
Thu Jun 8 15:17:42 UTC 2017
Oops here are the webrevs:
Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/
> 1. Added a comment in the LauncherCommon.gmk, fixed typo
> 2. Added checks for spurious EXTRA_JAVA_ARGS, both as
> compile time and runtime check, the latter for a good measure.
> PS: Mandy, could you please file a RFE for the jlink requirements and
> assign it to me.
>>> On Jun 7, 2017, at 2:58 PM, Kumar Srinivasan
>>> <kumar.x.srinivasan at oracle.com> wrote:
>>> Please review the changes to fix JDK-8180334, essentially
>>> -DJAVA_ARGS exceeds
>>> a Visual Studio C++ compiler limit, and this fix provides a way to
>>> very long string literals, by the build system.
>>> This also includes some minor and subtle simplifications and
>>> cleanups wrt.
>>> the JAVA_ARGS and its handling.
>>> Webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.00
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8180334
>> This is a reasonable short-term solution. As we discussed, we should
>> look into extending jlink to create the native launcher using @argfile
>> in a future release.
>> +# EXTRA_JAVA_ARGS Processed into a -DEXTRA_JAVA_ARGS and is prependedi
>> typo: s/prependedi/prepended
>> It may help to detect if main_jargc == 0 but extra_jargc > 0 and
>> exit with an error in case any bug in creating such a launcher.
More information about the core-libs-dev