RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris Hegarty chris.hegarty at oracle.com
Thu Jun 8 15:58:51 UTC 2017

> On 8 Jun 2017, at 16:52, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 08/06/2017 16:24, Igor Ignatyev wrote:
>> Chris/Alan,
>> Although the test itself doesn't launch new VMs,  jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on jdk.test.lib.process.* classes as it might start new VMs. [1] is the list of classes generated by running java/net/MulticastSocket/JoinLeave.java (w/o this patch) w/ a clean JTwork dir, @build directives were added for all these classes, this is exactly what was recommended by Jon in another thread[2].
> A long back, I wrote NetworkConfiguration to allow tests probe the network configuration. Chris did work in this area in recent times with a new version in test/lib/testlibrary. Now it seems to have moved again and has got tangled up in other test infrastructure. 

Just for clarity ( since Igor may need to some further work here ), I added a test library version of NetworkConfiguration that is used by the java.net tests, several of them iterate over network interfaces in a slightly different way. The version I added was subtly different from the version that Alan added in the NIO test subdirectory, so I did not change the NIO test tree in any way.

I did not review the consolidation of these files when the move to the top-level repo happen, I will need to recheck the changsets to find out what happened.


More information about the core-libs-dev mailing list