RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jun 9 06:42:38 UTC 2017

here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html <http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html>

there might be some new @build actions, b/c I have analyzed class files from all tests instead of looking only at ones which have jdk/test/lib classes.

-- Igor 

> On Jun 8, 2017, at 2:26 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> On Jun 8, 2017, at 9:35 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On 08/06/2017 17:18, Igor Ignatyev wrote:
>>> Alan,
>>> I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that NetworkConfiguration depending on Platform is a problem, I'd even say that NetworkConfiguration reimplementing methods from Platform is a problem. however even if we remove such dependencies now, one harmless refactoring of test libraries might get us back to instability of test results. it seems Jon has some ideas how to improve this situation, Ioi and I had several discussions about that as well, I believe we can come out w/ an elegant solution for this problem quite soon. meanwhile I'd echo Jon and recommend to apply these fixes to solve our current test execution problem.
>> I assume the issue with Platform is that it's using jdk.test.lib.Utils. If that dependency is removed (and it looks trivial) then would it reduce the @build usage in your patch?
> yes, it will remove some of @build actions, and this dependency seems to be unneeded and easy to remove. I'll remove it by a separate RFE and then refresh my patch.
> -- Igor

More information about the core-libs-dev mailing list