RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Igor Ignatyev igor.ignatyev at oracle.com
Mon Jun 12 21:13:38 UTC 2017

Hi Chris,

I haven't noticed your email and have already pushed 8181761. from my point of view, FileUtils depending on Platform class is not a bug, but having lots of seemed to be unrelated @build action is a bug,
I added your comment to 8181915 <https://bugs.openjdk.java.net/browse/JDK-8181915> so we won't forget about FileIUtils.

-- Igor

> On Jun 12, 2017, at 7:30 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> On 12/06/17 15:04, Alan Bateman wrote:
>> ...
>> For now, yes, I think these are okay. As part of the clean-up then it
>> would be good to update FileUtils to not use Platform and that would
>> avoid needing to build jdk.test.lib.Platform in several of these tests.
> I wrote the original FileUtils. Why was it changed to use Platform?
> The previous code was just reading a system property. Changing it
> to use Platform adds very little. Can this please be reverted? If
> so, then doing it before 8181761 would help reduce the churn in
> the code.
> -Chris.

More information about the core-libs-dev mailing list