JDK 10 RFR of JDK-8182465: Refactor shell test java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh to java

Alan Bateman Alan.Bateman at oracle.com
Tue Jun 20 14:19:04 UTC 2017

On 20/06/2017 08:50, Amy Lu wrote:
> java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh
> Please review this patch to refactor the shell test to java.
> bug: https://bugs.openjdk.java.net/browse/JDK-8182465
> webrev: http://cr.openjdk.java.net/~amlu/8182465/webrev.00/
I think it would be better to rename this to InheritedChannelTest.

Otherwise looks okay although I think I would read os.name and os.arch 
and avoid the Platform test library class for this.


More information about the core-libs-dev mailing list