JDK 9 RFR of JDK-8085814: Move stream test library to the jdk test library area

Paul Sandoz paul.sandoz at oracle.com
Mon May 8 17:33:30 UTC 2017

Hi Amy,

The changes look good.

Would you mind re-basing this fix for JDK 10 instead? At this point we should be more conservative with such changes (even for tests).


> On 8 May 2017, at 02:00, Amy Lu <amy.lu at oracle.com> wrote:
> Please review this test-only change to move the test library
> jdk/test/java/util/stream/bootlib
> to
> jdk/test/lib/testlibrary/bootlib
> to make it formally easier for tests to depend on.
> There is no change to the functionality of the tests.
> This patch also removed NullArgsTestCase.java which is an abstract class designed to be extended reused with a data provider. It provides no test itself but be wrongly put in the directory of TestNG.dirs thus be run as a test. In fact it is not even used and can be removed.
> bug:
> https://bugs.openjdk.java.net/browse/JDK-8085814
> https://bugs.openjdk.java.net/browse/JDK-8173414
> webrev:
> http://cr.openjdk.java.net/~amlu/8085814/webrev.00/
> (I did not update the year in the Copyright header for bootlib files, to make the review easier. I can do bulk update for those files on the header before push, if that is necessary.)
> Thanks,
> Amy

More information about the core-libs-dev mailing list