RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp
daniel.fuchs at oracle.com
Fri May 12 09:18:42 UTC 2017
On 12/05/2017 00:16, Kumar Srinivasan wrote:
> Hi Daniel,
> As Jon surmised, this is an ARIA/accessibility requirement, in that one
> have holes in the usage of h* tags, as javadoc tool itself uses h1 and h2,
> the API docs have to start with h3.
> With respect to your comment, the h2->h3 is erroneous and have reverted
> them back, so the only changes wrt. h* are h4 -> h3.
> New webrev: http://cr.openjdk.java.net/~ksrini/8179697/webrev.1/
This looks good now. Thanks for explaining the issue with holes in
the usage of h* tags - it makes it much easier to understand the
rationale behind the changes.
A few nits:
62 * <table><caption style="display:none">description</caption>
71 * <table><caption style="display:none">description</caption>
there are 2 spaces after 'caption'
82 <h4>Threading Issues</h4>
101 <h4>Exception Handling</h4>
I wonder if these two tags should be changed to <h3> as well,
so as not to introduce a hierarchy that was not there before.
(these do not seem to be sub-concepts of <h3>Naming Events</h3>
as far as I can see - but then I'm not a JNDI expert)
Otherwise looks good, no need for a new webrev.
>> Hi Kumar,
>> Looks mostly good.
>> I'm not too sure about the changes from <h4> to <h3> and <h2> to
>> <h3> though.
>> Now some of the package.html files in java.naming retain their
>> <h2>Package Specification</h2> section, and others have it
>> changed to <h3>Package Specification</h3>.
>> best regards,
>> -- daniel
>> On 10/05/2017 19:57, Kumar Srinivasan wrote:
>>> Please review HTML5 related changes to the above modules, please
>>> note there are no changes to the verbiage.
>>> Webrev: http://cr.openjdk.java.net/~ksrini/8179697/webrev.0/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179697
More information about the core-libs-dev