RFR(S) : 8180724: move ModuleInfoMaker to the top level testlibrary
igor.ignatyev at oracle.com
Wed May 24 22:08:32 UTC 2017
sure, if you prefer that style more, I'll undo these changes before pushing.
thanks for review.
> On May 24, 2017, at 2:19 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> On May 19, 2017, at 4:29 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> could you please review this small fix which moves ModuleInfoMaker class from jdk testlibrary to the top level testlibrary? since ModuleInfoMaker depends on CompilerUtil and thus on jdk.compiler module, it has been placed to jdk.test.lib.compiler package to avoid unneeded module dependency in tests. HashesTest has been updated to use ModuleInfoMaker::compile instead of using CompilerUtils::compile directly.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8180724/webrev.00/index.html
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8180724
>> testing: affected tests (jdk/test/tools/launcher)
> Nit: can you keep line 307-309, 386-387 unchanged?
> Otherwise, looks fine.
More information about the core-libs-dev