(10) RFR of JDK-8166142: Refactor java.io.serialization shell tests to java

Roger Riggs Roger.Riggs at Oracle.com
Thu May 25 18:54:33 UTC 2017

Hi Hamlin,

For imports they should import specific classes, wildcards are not used.


  test/java/io/Serializable/packageAccess/Driver.java: the name "Driver" 
is not descriptive and should be.

Each Driver.java should have a different and functional/descriptive name.

Better yet, there should be a single program that creates jar files 
using command line arguments
that can be invoked depending on the test.

There is a mix of Driver's copying files vs the test program copying; 
can that be made more uniform.

Test.java files should have descriptive/functional names. (Even if the 
duplicating the directory)

Regards, Roger

On 5/24/2017 5:09 AM, Hamlin Li wrote:
> Would you please review the below patch?
> bug: https://bugs.openjdk.java.net/browse/JDK-8166142
> webrev: http://cr.openjdk.java.net/~mli/8166142/webrev.00/
> Thank you
> -Hamlin

More information about the core-libs-dev mailing list