RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner
igor.ignatyev at oracle.com
Wed May 31 21:57:33 UTC 2017
8180793, which moved j.t.l.wrappers.* to j.t.lib package, has been propagated to jdk10/jdk10. I have updated the patch accordingly -- http://cr.openjdk.java.net/~iignatyev//8180386/webrev.01/index.html
could you please take a look?
> On May 18, 2017, at 2:49 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> On May 18, 2017, at 2:41 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>> On May 18, 2017, at 2:37 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>> On May 18, 2017, at 2:34 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>>> This comment is not related to the change. The package name `jdk.test.lib.wrappers` is odd. TimeLimitedRunner and InfiniteLoop classes could simply be in the jdk.test.lib package or jdk.test.lib.util package.
>>> agree, I'll file an RFE to find a better package for TimeLimitedRunner and InfiniteLoop classes.
>> Why not doing the rename with this patch?
> there are hotspot tests which use jdk.test.lib.wrappers.TimeLimitedRunner and InfiniteLoop, so it will require changes in hotspot repo. I'd prefer to have removing classes from jdk testlibrary and renaming classes in top level testlibrary as separate patches for clarity purposes.
> -- Igor
More information about the core-libs-dev