RFR: 8189102: All tools should support -?, -h and --help

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Nov 17 18:29:52 UTC 2017


I understand why you might want to ensure that a basic set of help 
options is supported,
but I don't understand why that justifies removing older options, like 
"-help" for many tools.

In addition, I notice the CSR says:

> *Compatibility Risk Description:* 
> <https://bugs.openjdk.java.net/browse/JDK-8191477#> Only new flags are 
> added, none removed.

But that is not true, since your edits for javac and javadoc remove the 
option completely.

Also, in the CSR, look for these typos:
     OpenJdk (should be OpenJDK)

Also, I note that you've changed localized resource files. The usual 
procedure is to never
touch those files, since they get updated later by Oracle's localization 

-- Jon

On 11/17/2017 03:23 AM, Lindenmaier, Goetz wrote:
> Hi,
> please review this change. I also filed a CSR for this:
> http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
> CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
> See the webrev for a detailed description of the changes.
> If required, I'll make break-out changes to be reviewed separately.
> I had posted a RFR before, but improved the change to
> give a more complete overview of currently supported flags
> for the CSR:
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-October/028615.html
> Best regards,
>    Goetz.

More information about the core-libs-dev mailing list