RFR: JDK-8189611: JarFile versioned stream and real name support

Alan Bateman Alan.Bateman at oracle.com
Tue Nov 21 11:25:06 UTC 2017

On 21/11/2017 02:58, Xueming Shen wrote:
> :
> http://cr.openjdk.java.net/~sherman/8189611/webrev
> jdeps' VersionHelper.java still accesses the "getRealName()" via the 
> SharedSecrets.
> Since jdeps is being compiled/built with the bootjdk, I'm leaving it 
> untouched for
> now.
I think we need to create an issue in JIRA to get jdeps updated. It 
actually has two issues, the other is the usage of 
jdk.internal.util.jar.VersionedStream. I'm surprised that there are 
issues with the boot JDK because it uses both in JDK 9 when the boot JDK 
is JDK 8. No issue with keeping this separate to the current effort.

I've skimmed through the latest webrev and it looks good good. The 
JarEntry::getRealName and JarFile::versionedStream APIs look good.

The update to jlink to use the standard API should mean that java.base 
no longer needs to export jdk.internal.util.jar to jdk.jlink.

JarFile is updated to import LinkedHashMap, I don't think that is needed 
in this version.

I think that is all I have for now.


More information about the core-libs-dev mailing list