<i18n dev>  RFR 8191404: Upgrading JDK with latest available LSR data from IANA.
naoto.sato at oracle.com
Wed Nov 22 17:18:27 UTC 2017
Looks good. As long as sampling the test data is meaningful, I think
On 11/22/17 12:13 AM, Nishit Jain wrote:
> Thanks Naoto,
> > One nit in the test. At line 71, probably the original intention of
> "str" is to list the accept languages in alphabetic order. Would you
> change it?
> Yes, it is sorted according to weight then alphabetically. Updated the
> test case.
> > I have not looked into actual tags in the test. Did you modify them
> manually? If so, it would be desirable to make it automated.
> Yes, currently the updated tags are added in the test case manually.
> Making it automated is in the target list, will file/take it as a
> separate issue.
> I would like to bring one point to notice that, I have not added all the
> new tags (which are added in this version) in the test case, just few of
> them are added to test that LocaleEquivalentMaps are properly updated.
> Hope that is fine.
> Nishit Jain
> On 22-11-2017 04:47, Naoto Sato wrote:
>> Hi Nishit,
>> One nit in the test. At line 71, probably the original intention of
>> "str" is to list the accept languages in alphabetic order. Would you
>> change it?
>> I have not looked into actual tags in the test. Did you modify them
>> manually? If so, it would be desirable to make it automated.
>> On 11/16/17 3:47 AM, Nishit Jain wrote:
>>> Please review the fix for JDK-8191404
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
>>> Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/
>>> Fix: Updated the LSR data with the version: 2017-08-15
>>> Nishit Jain
More information about the core-libs-dev