6516099: InputStream.skipFully(int k) to skip exactly k bytes

Brian Burkhalter brian.burkhalter at oracle.com
Wed Dec 5 01:07:06 UTC 2018

Hi Daniel,

You are correct: at line 154 ’n’ should have been passed instead of ‘-1’ here:

http://cr.openjdk.java.net/~bpb/6516099/webrev.08-delta/ <http://cr.openjdk.java.net/~bpb/6516099/webrev.08-delta/test/jdk/java/io/InputStream/Skip.java.frames.html>

Fixing that exposed an error in the test at line 222 which I’ve fixed.

An updated version is at

http://cr.openjdk.java.net/~bpb/6516099/webrev.09/ <http://cr.openjdk.java.net/~bpb/6516099/webrev.09/>

with the 08-09 delta at

http://cr.openjdk.java.net/~bpb/6516099/webrev.08-09-delta/ <http://cr.openjdk.java.net/~bpb/6516099/webrev.08-09-delta/>



> On Dec 3, 2018, at 9:27 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> Looks good to me, though I don't understand the change
> at line 154:
> The comment says:
> 152         // skip(n) returns negative value: IOE
> but if you pass -1 - you're no longer calling skip(n)?

More information about the core-libs-dev mailing list