RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
philip.race at oracle.com
Tue Dec 11 17:44:36 UTC 2018
1) Thanks for uploading the webrev. much better for one person to do
this than make
everyone who wants to look at it go through a tedious and off-putting
set of steps.
2) I've added some client lists since you are touching UI client files,
not just core-libs.
To me the client ones look OK, one looks more like it was a typo
than anything intentional,
and the other was pretty mild.
3) Regarding the comment in the bug report about hb-private.hh and the
/* CRAP pool: Common Region for Access Protection. */
since it not only is in an upstream library, but also used 14 times in
then I can't possibly agree with your comment that an argument for
would be "shaky". Take this up with the upstream library ... I have no
renaming these every time we upgrade this library.
On 12/11/18 8:45 AM, Adam Farley8 wrote:
> Sure thing:
> Best Regards
> Adam Farley
> IBM Runtimes
> Volker Simonis <volker.simonis at gmail.com> wrote on 11/12/2018 15:46:44:
>> From: Volker Simonis <volker.simonis at gmail.com>
>> To: adam.farley at uk.ibm.com
>> Cc: Java Core Libs <core-libs-dev at openjdk.java.net>
>> Date: 11/12/2018 15:47
>> Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
>> Hi Adam,
>> in order to prevent me from using swear words, could you please upload
>> your webrev to cr.openjdk.java.net :)
>> As you may have realized webrevs are a collection of HTML files and it
>> makes no big sense to provide them as a zip file.
>> Thank you and best regards,
>> On Tue, Dec 11, 2018 at 4:04 PM Adam Farley8 <adam.farley at uk.ibm.com>
>>> Hey All,
>>> I've spotted 12 instances of swear words in OpenJDK source comments,
>>> it seems appropriate to remove them.
>>> Bug: INVALID URI REMOVED
>>> I've created a webrev and attached to the bug.
>>> Also, I've mentioned in the bug that there are additional swears in
>>> excusable locations. It would be good to get the community's take on
>>> Reviews and opinions welcome. :)
>>> Best Regards
>>> Adam Farley
>>> IBM Runtimes
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
More information about the core-libs-dev