RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

Doerr, Martin martin.doerr at sap.com
Wed Dec 12 07:10:24 UTC 2018

Hi Gustavo,

thanks for your improvements. You can also remove the trailing \t from the opto assembly.
Note that there's no need to re-push newer version to jdk/submit when only PPC files were changed. jdk/submit doesn't look at them.

Best regards,

-----Original Message-----
From: Gustavo Romero <gromero at linux.vnet.ibm.com> 
Sent: Mittwoch, 12. Dezember 2018 03:08
To: Michihiro Horie <HORIE at jp.ibm.com>
Cc: core-libs-dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>; Roger Riggs <Roger.Riggs at oracle.com>; Vladimir Kozlov <vladimir.kozlov at oracle.com>; Simonis, Volker <volker.simonis at sap.com>
Subject: Re: RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

Hi Michi,

On 12/11/2018 11:12 PM, Michihiro Horie wrote:
> Thank you for finding the issue on Power8. You do not need a check with has_darn in the ppc.ad. It is better to add a check in vm_versoin_ppc.

I agree.

> I uploaded webrev.08 based on your webrev.07. (Thanks for the enhancement of opto assembly and removing trailing spaces!)
> http://cr.openjdk.java.net/~mhorie/8213754/webrev.08/ <http://cr.openjdk.java.net/%7Emhorie/8213754/webrev.08/>

Thanks for the updated webrev. Looks good!
I've just pushed webrev.08 to jdk/submit expecting no failures as .07 passed fine.

Once I get the jdk/submit results tomorrow I'll push.

Best regards,

More information about the core-libs-dev mailing list