RFR (S): 8215472: Cleanups in implementation classes of jdk.zipfs and tests

Claes Redestad claes.redestad at oracle.com
Mon Dec 17 10:38:07 UTC 2018

Hi Christoph,

I believe the convention in the OpenJDK sources is to sort static
imports after non-static, so changing to the other way around in a few
places adds inconsistencies.

In ZipFileSystem you remove the unused method releaseDeflater - to me
this indicates the resource pooling is actually broken? I.e., shouldn't
EntryOutputStreamDef return its Deflater to the cache when it's closed,
similar to how the anonymous InflaterInputStream in getInputStream does
it? As it's currently implemented the deflaters list will always be
empty and no Deflater returned, so could go the other way and remove
that cache if caching Deflaters isn't useful.

Otherwise looks good to me.


On 2018-12-17 09:28, Langer, Christoph wrote:
> Hi,
> when working with jdk.zipfs, I found some opportunity for cleanups. I'd like to contribute this independently from my other thread regarding Posix permissions in zip files (http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-November/056426.html). So, please help to review the cleanup.
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8215472.0/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215472
> Thanks
> Christoph

More information about the core-libs-dev mailing list