RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

Lance Andersen lance.andersen at oracle.com
Thu Dec 20 14:17:47 UTC 2018

Hi Philipp,

The tests look better.  Any chance you can post the webrev in the future vs the patch as it makes it easer to review.

> On Dec 19, 2018, at 1:24 AM, Philipp Kunz <philipp.kunz at paratix.ch> wrote:
> now with assertThrows. Find a new patch attached.
> On Tue, 2018-12-18 at 13:38 -0800, Martin Buchholz wrote:
>> On Tue, Dec 18, 2018 at 1:13 PM Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>>
>> wrote:
>>> Is there a reason you did not use
>>> @Test(expectedExceptions = IOException.class)
>>> It just seems to make the test a bit more readable
>>> That construct has lost popularity over the past decade, sort of like
>> inheritance is no longer considered a silver bullet.
> <8066619.patch>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list