RFR: 8041626: [Event Request] Shutdown reason
robin.westberg at oracle.com
Fri Feb 9 15:41:20 UTC 2018
> On 7 Feb 2018, at 21:47, Erik Gahlin <erik.gahlin at oracle.com> wrote:
> Hi Robin,
> I can sponsor this.
> I wonder if we should change the name of the event to "Shutdown" instead? It will give us flexibility to add other shutdown related fields in the future.
Makes sense, I’ll rename it.
> Could you change the label and field to "Status Code" and statusCode. Event fields should have headline-style capitalization and statusCode allows us to add other status related information in the future.
Removed the status field now, I’ll keep it in mind if it gets added back in the future.
>> Hi all,
>> Please review the following change that adds an event-based tracing event that is generated when the VM shuts down. The intent is to capture shutdowns that occur after the VM has been properly initialized (as initialization problems would most likely mean that the tracing framework hasn’t been properly started either).
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8041626 <https://bugs.openjdk.java.net/browse/JDK-8041626>
>> Webrev: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.00/ <http://cr.openjdk.java.net/%7Erwestberg/8041626/webrev.00/>
>> Testing: hs-tier1,hs-tier2,jdk-tier1,jdk-tier2
>> Best regards,
More information about the core-libs-dev