JDK-6372077: JarFile.getManifest() should handle manifest attribute names up to 70 bytes

Alan Bateman Alan.Bateman at oracle.com
Mon Feb 26 11:50:00 UTC 2018

On 23/02/2018 19:58, Roger Riggs wrote:
> Please review this contribution from Philipp Kunz to handle manifest 
> attribute names up to 70 bytes.
> The change passes the available regression tests.
> Manifest handling is somewhat sensitive so an additional review is 
> appreciated.
> Webrev: (rebased from the original patch of 2/22/18)
>     http://cr.openjdk.java.net/~rriggs/webrev-jar-6372077.patch/
> Issue:
>    https://bugs.openjdk.java.net/browse/JDK-6372077
I looked at the changes to the manifest code and I think they are okay. 
I don't have time to study the tests in detail.

I think it would be useful to copy the clarification note "(there must 
be a colon and a SPACE after the name)" from the JAR file spec to the 
equivalent sentence in the Attributes class description. That will help 
anyone wondering why the limit is 70 rather than 72. This change 
shouldn't need a CSR as it's not adding any new assertions.


More information about the core-libs-dev mailing list