RFR(XXS) : 8190679 : java/util/Arrays/TimSortStackSize2.java fails with "Initial heap size set to a larger value than the maximum heap size"
david.holmes at oracle.com
Wed Feb 28 04:33:29 UTC 2018
On 28/02/2018 7:17 AM, Igor Ignatyev wrote:
> Hi David,
> I have set Xmx equal to Xms, the test passes w/ different externally
> passed combinations of Xmx, Xms and UseCompressedOops.
> -- Igor
>> On Feb 26, 2018, at 9:00 PM, David Holmes <david.holmes at oracle.com
>> <mailto:david.holmes at oracle.com>> wrote:
>> Hi Igor,
>> On 27/02/2018 11:25 AM, Igor Ignatyev wrote:
>>>> 9 lines changed: 2 ins; 0 del; 7 mod;
>>> Hi all,
>>> could you please review the patch for TimSortStackSize2 test?
>>> the test failed when externally passed (via -javaoption or -vmoption)
>>> -Xmx value is less than 770m or 385m, depending on UseCompressedOops.
>>> it happened because the test explicitly set Xms value, but didn't set
>>> now, the test sets Xmx as Xms times 2.
>> I'm not happy with setting Xmx at 2 times Xms - that seems to be
>> setting ourselves up for another case where we can't set -Xmx at
>> startup. This test has encountered problems in the past with external
>> flag settings - see in particular the review thread for JDK-8075071:
>> Will the test pass if we simply set -Xmx and -Xms to the same? Or
>> (equivalently based on on previous review discussions) just set -Xmx
>> instead of -Xms?
>>> PS as it mostly affects hotspot testing, the patch will be pushed to
>>> testing: java/util/Arrays/TimSortStackSize2.java w/ and w/o
>>> externally provided Xmx value
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8190679
>>> -- Igor
More information about the core-libs-dev