RFR: 8193660 Check SOURCE line in "release" file for closedjdk

Randy Crihfield Randy.Crihfield at Oracle.com
Wed Feb 28 18:15:37 UTC 2018

On 02/28/18 11:58 AM, Alan Bateman wrote:
> On 28/02/2018 16:57, Randy Crihfield wrote:
>> poke poke can someone please review?  Thanks
> The `release` is a properties file so I assume you can simplify the 
> test by using Properties.load and then testing if the "SOURCE" key is 
> present and whether it has the expected value.
> -Alan.

I could though I actually already wrote the test as requested initially 
and read the file as desired at that time, which is in the workspace.

The current incantation is to expand the test to also check a closed 
build and streamline, rather than write two tests.

I would like to get approval as it is, but if I need to go back and 
change existing behavior I will.


More information about the core-libs-dev mailing list