[JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat
daniel.fuchs at oracle.com
Tue Jan 23 10:27:34 UTC 2018
On 22/01/2018 21:30, Jason Mehrens wrote:
> Fantastic! The patch looks good as is. The only > thing that sticks out is that both the 'if' and
> the 'else if' have the same code inside them.
> That could be refactored a bit.
I had the same feeling - but then when looking at
possible refactoring I came to the conclusion that
I liked the explicit if / else if / better.
The duplicated code is just one line + one return
so it's not that bad.
More information about the core-libs-dev