Review Request: JDK-8211921,,AssertionError in MethodHandles$Lookup.defineClass

Mandy Chung mandy.chung at
Wed Oct 10 21:03:48 UTC 2018

On 10/10/18 1:41 PM, Alan Bateman wrote:
> On 10/10/2018 21:38, Mandy Chung wrote:
>> :
>> This assertion is not strictly necessary and
>> test/jdk/java/lang/invoke/ verifies these
>> properties of the resulting Class.  I propose to remove this
>> assertion.
> An alternative is to just drop the PD check from the assertion, the 
> check that defining class loader and package should never fail. Either 
> is okay with me.

If the loader or package is not the one expected, it's a serious bug and 
also the DefineClassTest test will catch it.  I opt to take this out as 
the assertion does not seem adding much value.


More information about the core-libs-dev mailing list