RFR [12] 8212001: Verify exported symbols in java.base (libjava)

Roger Riggs Roger.Riggs at oracle.com
Thu Oct 11 13:10:19 UTC 2018

Hi Pavel,

Looks fine.

The JNICALL macro is used by the C compiler to force a particular native 
calling convention (API).
ABI - Application binary interface that defines the stack and register 
usage when calling native functions.

On Windows it is defined as __stdcall, which is the default so there is 
no change in behavior if it is missing.
See src/java.base/*/native/include/jni_md.h

It seems most native function declarations include JNICALL.

Possibly this should be a separate cleanup but being consistent within 
each native source file would be a good start.


On 10/11/2018 08:30 AM, Chris Hegarty wrote:
>> On 11 Oct 2018, at 13:28, Pavel Rappo <pavel.rappo at oracle.com> wrote:
>> Hello,
>> Please review the following change:
>> http://cr.openjdk.java.net/~prappo/8212001/webrev.00 <http://cr.openjdk.java.net/~prappo/8212001/webrev.00>
> This looks good. Thanks Pavel.
> -Chris.

More information about the core-libs-dev mailing list