RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

Alan Bateman Alan.Bateman at oracle.com
Sun Oct 14 18:08:36 UTC 2018

On 12/10/2018 20:16, Joe Wang wrote:
> Hi all,
> Here's an update based on all of the great reviews and comments 
> (thanks all!):
> JBS: https://bugs.openjdk.java.net/browse/JDK-8202285
> CSR: https://bugs.openjdk.java.net/browse/JDK-8202302
> Current version:
> specdiff: 
> http://cr.openjdk.java.net/~joehw/jdk12/8202285/specdiff_02/java/nio/file/Files.html
> webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v02/
I think the javadoc looks good now.

I agree that starting with a simple implementation is okay, it can be 
improved in time. One thing to fix is totalRead that needs to be a long 
to give the correct result on large files that mismatch at position > 2GB.


More information about the core-libs-dev mailing list