RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019
matthias.baesken at sap.com
Mon Oct 22 11:18:47 UTC 2018
Hi Alan , in case there is a re-release of Windows server 2019 the buildNumber might (or might not) increase.
But it will not decrease.
So I think we are fine with the current check .
> although I assume we need to be cautious about back porting
Sure we can wait a couple of weeks before backporting it to jdk11u .
Best regards, Matthias
> -----Original Message-----
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Samstag, 20. Oktober 2018 10:06
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Cc: hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>; core-
> libs-dev at openjdk.java.net; Moldenhauer, Niclas
> <niclas.moldenhauer at sap.com>
> Subject: Re: RFR : 8211106: [windows] Update OS detection code to
> recognize Windows Server 2019
> On 19/10/2018 13:11, Baesken, Matthias wrote:
> > Hi Alan, I agree it is a pity that the minor version (dwMinorVersion) was
> not increased .
> > Looking at the build number was not my preferred way to handle this .
> > My understanding (checked with our internal SAP-MS porting guys) is
> that the buildNumber of Windows server 2016 will not get larger than
> > the minimum introduced buildNumber of Windows server 2019 .
> The changes in your webrev look okay to me although I assume we need to
> be cautious about back porting until it becomes clear if Windows Server
> 2019 will be re-released or not. The Windows Server blog  suggests
> that the release is paused while an issue is investigated and maybe a
> re-release will mean a new build number at least.
More information about the core-libs-dev