RFR of JDK-8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test
amy.lu at oracle.com
Wed Oct 24 02:07:43 UTC 2018
Thank you Brent for the comments!
All fixed in the new webrev:
On 2018/10/24 4:39 AM, Brent Christian wrote:
> Hi, Amy
> I think this looks quite good as it is. Just a couple very minor
> comments, that you can take or leave:
> * I don't think a List<String> is needed for the 'expected' argument,
> it can just be a String. The @DataProvider should be able to return
> Objects of a List<String> and a String.
> * Really, the argument to PrefsSpi is a regex pattern, rather than an
> expected result.
> So overall testProvider() could look like:
> public void testProvider(List<String> opts, String pattern) throws
> * Also, maybe update the comment (+ copyright year, I suppose) in
> * main class used by regtest PrefsSpi.sh
> On 10/22/18 8:44 PM, Amy Lu wrote:
>> Please review this patch to refactor above shell script test to java.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8210908
>> webrev: http://cr.openjdk.java.net/~amlu/8210908/webrev.00/
More information about the core-libs-dev