RFR: 8139965 - Hang seen when using com.sun.jndi.ldap.search.replyQueueSize
daniel.fuchs at oracle.com
Fri Oct 26 15:14:49 UTC 2018
Looks better to me know. Though I admit that:
53 this.replies = new LinkedBlockingQueue<>(8 *
replyQueueCapacity / 10);
is still a bit mystifying... Why not use the full
replyQueueCapacity provided? That doesn't look
strictly equivalent to the highWatermark logic that
you have removed.
On 25/10/2018 21:53, Rob McKenna wrote:
> I'm planning to follow up on the test side of things with a separate
> bug. I think the technique used in some of the recent SQE LDAP tests
> might be applicable.
It will be good to have a test and try to shake the implementation
a bit with some repeating jobs in our test system to get some
confidence that we've not harmed anything else.
I admit that my only acquaintance to the JNDI/LDAP code of the JDK
has been through reviews, so I'd probably only spot the obvious.
On 26/10/2018 15:55, Rob McKenna wrote:
> Thanks again Daniel,
More information about the core-libs-dev