[RFR] 8160768: Add capability to custom resolve host/domain names within the default JDNI LDAP provider

vyom tewari vyom.tewari at oracle.com
Tue Oct 30 09:22:47 UTC 2018

Hi Rob,

Overall your code looks OK to me, In LdapDnsProviderService.java please 
make 'service' as volatile otherwise 'getInstance()' may not work as 
expected. I can see you implemented DCL but it may not work if 'service' 
is not declare volatile.

If you like, you can us the initialization 'On Demand Holder idiom' to 
implement the lazy initialization.



On 26/10/18 8:31 PM, Rob McKenna wrote:
> Yes, thanks a lot Alan.
> Vyom and Martin both had some very helpful feedback so I'm hoping to
> hear from both!
>      -Rob
> On 26/10/18 15:34, Alan Bateman wrote:
>> On 25/10/2018 17:34, Rob McKenna wrote:
>>> This recently received CSR approval, so it seems like a good time to pick
>>> the codereview up again:
>>> http://cr.openjdk.java.net/~robm/8160768/webrev.08/
>> I went through a number of iterations with Rob on the API/javadoc so I think
>> the API parts in webrev.08 are good. I have not had time to go through the
>> implementation and test changes so hopefully that someone else has cycles to
>> help on that.
>> -Alan

More information about the core-libs-dev mailing list