RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java
xu.y.yin at oracle.com
Mon Sep 10 09:13:21 UTC 2018
Thank you, Alan
Sure, I modified a little to remove “.” and use Path.of as you suggested to improve file handling, minor revision as below, thanks
> On 10 Sep 2018, at 3:20 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 30/08/2018 10:06, vyom tewari wrote:
>> Hi Chris,
>> The refactored java class (RunBasic.java) looks good to me.
> Looks okay to me too but the file handling could be improved, e.g. no need to resolve path against ".", should specify the elements to Path.of so that they use the right separator for the platform.
More information about the core-libs-dev