[RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Langer, Christoph christoph.langer at sap.com
Mon Sep 10 19:29:42 UTC 2018


> > do you think we need property jdk.includeInExceptions=jar<File/Path> at
> all, if we don't resolve the absolute path?
> I think so. File path is still sensitive.
> In fact, I tend to believe people usually use absolute paths for JAR files (or
> maybe made absolute by using a file:// URL somewhere inside JDK). Do you
> really see relative jar paths while testing this code change?

I agree.

> > small remark to the code:
> > src/java.base/share/classes/sun/security/util/SecurityProperties.java
> > 36     public static String privilegeGetOverridable(String propName) {
> >
> > Should that method really be public? At the moment it doesn't seem to be
> used outside of SecurityProperties.
> I like it to be public. There are quite some other such system/security
> properties (Ex: jdk.serialFilter) that can make use of this method.

Ok, maybe it should be named "priviledgedGetOverridable" then.

Further small cleanups, as you touch the files:
src/java.base/share/classes/java/util/jar/Manifest.java: line 35: you can remove "import java.util.Iterator;"

line 41: indentation is ridiculously long, I think it should be 8 chars

Indentation of lines 38-45 is too deep, should be 12.
The 2 methods could use a brief Javadoc.

Best regards

More information about the core-libs-dev mailing list