RFR - JDK-8210718 String::detab, String::entab (CSR Review)

Roger Riggs roger.riggs at oracle.com
Tue Sep 18 19:40:24 UTC 2018

Hi Jim,

It may be useful to be more specific about the definition of a tab stop.
In this context I think you mean the next multiple of 'n' greater than 
the current position + 1.
(And not taking into account surrogates, high and low) as 1 character or 2.
In some other contexts, tab stops can be specified as an explicit list 
of offsets from the start of the line.

Is there always at least one " " (space) replacing the tab?

In the exceptions, a typo: "less that equals"

In entab(), the "replaces some space characters... spacing aligns" seems 
a bit vague.
(I don't want to read the code to have a precise understanding.)

Thanks, Roger

On 9/18/18 1:52 PM, Jim Laskey wrote:
> Please review the API for String::detab and String::entab. Used to expand tabs into spaces, and spaces back to tabs.
> csr: https://bugs.openjdk.java.net/browse/JDK-8210718
> jbs: https://bugs.openjdk.java.net/browse/JDK-8210717
> Cheers,
> — Jim

More information about the core-libs-dev mailing list