RFR: 8224974: Implement JEP 352

Dmitry Chuyko dmitry.chuyko at bell-sw.com
Thu Aug 1 04:09:30 UTC 2019

Hi Andrew,

Just a small comment about the tests. As you can see, some of tests in 
jdk/java/nio/channels/FileChannel check various modes, arguments, and 
expected exceptions. E.g. see MapTest, Mode and Args.

I noticed that in your changes for the new map mode there are new 
exceptions thrown in different situations. For example, when the 
required mode is not supported, or it does not fit. In particular, this 
should happen correctly on systems that do not support nvram. Have you 
considered the possibility of extending or adding tests for this behavior?


On 7/31/19 1:55 PM, Andrew Dinn wrote:
> Hi Aleksey
> On 30/07/2019 17:00, Aleksey Shipilev wrote:
>> On 7/30/19 5:04 PM, Andrew Dinn wrote:
>> ...........................
> Sure, welcome to the party even if most of the booze has been drunk :-)
> Thank you for a very thorough review. Comments (mostly in agreement) are
> inline below. They include a few refusals and a walk past some of the
> jumps pending confirmation they truly form part of the obstacle course.
> A new webrev against the latest jdk/jdk dev tree including all
> uncontested changes is here:
>    http://cr.openjdk.java.net/~adinn/8224974/webrev.10/
>> === General:..................................

More information about the core-libs-dev mailing list