RFR [14] 8217606: LdapContext#reconnect always opens a new connection

Pavel Rappo pavel.rappo at oracle.com
Wed Aug 7 18:39:15 UTC 2019

> On 7 Aug 2019, at 18:49, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> <snip>
> It seemed unnecessary/redundant since except for isRunning it is updated inside a synchronize(lock).

Pardon, what seemed unnecessary?

> The synchronized(socketList) is also unnecessary since it is already synchronized on lock.

You are right, this is redundant, albeit harmless. It might be a leftover from
one of the design iterations we've had when synchronization was more
fine-grained. I'll remove all the synchronization on `socketList`.


More information about the core-libs-dev mailing list