RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

naoto.sato at oracle.com naoto.sato at oracle.com
Mon Aug 12 22:01:34 UTC 2019

Thank you for the review, Lance.

On 8/12/19 2:37 PM, Lance Andersen wrote:
> Looks good Naoto.
> One question I had which is not relevant to your fix, but should the 
> tests as we modify them include the JTReg tags such as @bug, @summary…. 
> etc…  just for consistency….

I put @bug tags to each of the modified test, but not @summary, et.al. 
It seems that each test file corresponds to the java.time class, so 
adding @summary for this bug might not fit. I could add @summary to 
existing "Tests XXXX" statement, but keep it consistent with other 
java.time test case files.


> Best
> Lance
>> On Aug 12, 2019, at 4:43 PM, naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com> wrote:
>> Hello,
>> Please review the fix to the following issue:
>> https://bugs.openjdk.java.net/browse/JDK-8211990
>> The proposed changeset is located at:
>> https://cr.openjdk.java.net/~naoto/8211990/webrev.00/
>> The DateTimeException was thrown due to unconditional conversion 
>> beyond the valid range of the internal LocalDateTime value. If it 
>> happens, normalize two instants with the offset of "start" instant. 
>> The same kind of exception is observed with ZonedDateTime.until(), 
>> which is also fixed in this changeset.
>> Naoto
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list