[JDK 14] RFR 8230004: jdk/internal/jimage/JImageOpenTest.java runs no test

Alan Bateman Alan.Bateman at oracle.com
Fri Aug 30 06:50:20 UTC 2019

On 30/08/2019 03:34, Amy Lu wrote:
> jdk/internal/jimage/JImageOpenTest.java
> This test is not a testng test, and is not running any test after 
> TEST.properties was introduced at the same directory with:
> TestNG.dirs = .
> There are two tests in this directory: JImageReadTest is a testng 
> test, JImageOpenTest is not.
> It's safe to remove testng related settings from TEST.properties, and 
> specify that in JImageReadTest.
> Other issues found:
> 1. JImageOpenTest.java has a wrong build tag, which can be removed.
> 2. To override the default limit for the amount of output that will be 
> saved on any stream being recorded by the test harness in 
> TEST.properties, maxOutputSize should be used, instead of 
> javatest.maxOutputSize [1]. This issue also exists in some other tests 
> and will be fixed in [2].
> Please review the patch to fix these issues and get 
> JImageOpenTest.java back.
> bug: https://bugs.openjdk.java.net/browse/JDK-8230004
> webrev: http://cr.openjdk.java.net/~amlu/8230004
This looks okay.


More information about the core-libs-dev mailing list