RFR: JEP 359: Records (Preview) (full code)

John Rose john.r.rose at oracle.com
Tue Dec 3 01:08:54 UTC 2019

On Dec 2, 2019, at 4:36 PM, David Holmes <david.holmes at oracle.com> wrote:
> You are using CHECK_0 in RecordComponent::create but that method returns oop. That seems wrong to me, but I see many other oop returning methods also use CHECK_0 so I'll take that up separately. (It's only a cosmetic issue.)

CHECK_NULL is clearly preferable.  At some point IIRC it was more
than just cosmetics, because we were getting warning noise about
`return 0` converting to NULL, from some C++ compiler or other.
AFAIK such warnings can still happen.

— John

More information about the core-libs-dev mailing list