<i18n dev>  RFR: 8222756: Plural support in CompactNumberFormat
huizhe.wang at oracle.com
Wed Dec 4 18:12:03 UTC 2019
Looks good. I understand you'll update the webrev (with the added
statement to readObject) once the CSR is approved.
ResourceBundleGenerator.java might have been accidentally touched as
there's no change there.
I wonder if you need to guard the pluralRules input since you're
building a Map with a split. While it normally won't be a problem if the
factory methods are used, there's still a chance CompactNumberFormat is
constructed directly (e.g. with a custom format).
On 11/26/19 1:35 PM, naoto.sato at oracle.com wrote:
> I modified CompactNumberFormat.java to simplify the syntax parsing:
> Please review this webrev instead.
> On 11/25/19 1:16 PM, naoto.sato at oracle.com wrote:
>> CompactNumberFormat has been added since JDK 12 to support compact
>> number formatting, such as 10_000 being formatted as "10K."  It
>> works fine for English, however, not for other languages that take
>> plural forms in formatted number prefixes/suffixes. In order to fix
>> this, I filed the following CSR to extend the current
>> CompactNumberFormat spec:
>> It basically accommodates the plural prefix/suffix forms into the
>> existing compact patterns array, so that the existing compact number
>> format works compatibly. The plural rules are solely based on the
>> CLDR's plural language rules 
>> Here is the implementation of the CSR:
>> Please review the CSR as well as its implementation.
>>  https://bugs.openjdk.java.net/browse/JDK-8177552
More information about the core-libs-dev