RFR (trivial): 8235833: PosixPlatform.cpp should not include sysctl.h
alexey.semenyuk at oracle.com
Thu Dec 12 16:42:17 UTC 2019
On 12/12/2019 8:23 AM, Yasumasa Suenaga wrote:
> Hi Andrew,
> I can see same error whether --disable-precompiled-headers or not.
> So I filed it to JBS and uploaded webrev.
> Could you review it?
> JBS: https://bugs.openjdk.java.net/browse/JDK-8235833
> webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8235833/webrev.00/
> It works fine on Fedora 31.
> I've pushed it to submit repo. I believe it passes all tests.
> On 2019/12/12 19:25, Andrew Haley wrote:
>> On 12/12/19 9:31 AM, Yasumasa Suenaga wrote:
>>> AFAICS sysctl.h provides `sysctl()` and some macros, but they are
>>> not used in PosixPlatform.cpp .
>>> In fact, I did not see any error when I remove `#include
>>> <sys/sysctl.h>` from it.
>> You probably won't see an error unless you configure with
>> --disable-precompiled-headers. Please try that, and we can then
>> consider removing that #include.
More information about the core-libs-dev