RFR 8234362: k_standard.c is not needed and should be removed
fweimer at redhat.com
Fri Dec 20 15:45:43 UTC 2019
* Florian Weimer:
> * Florian Weimer:
>> __kernel_standard in src/java.base/share/native/libfdlibm/k_standard.c
>> is built for _IEEE_LIBM targets as well, but it appears superfluous
>> In noticed this because GCC 10 flags an uninitialized variable in this
>> …/src/java.base/share/native/libfdlibm/k_standard.c: In function '__j__kernel_standard':
>> …/src/java.base/share/native/libfdlibm/k_standard.c:743:19: error: 'exc.retval' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> 743 | return exc.retval;
>> | ~~~^~~~~~~
>> Rather than debating whether this warning is reasonableor not, I would
>> suggest to #ifdef out this code for _IEEE_LIBM targets (are there any
>> else left?).
> I think the file should just be removed.
> Bug: <https://bugs.openjdk.java.net/browse/JDK-8234362>
> Webrev: <http://cr.openjdk.java.net/~fweimer/8234362/webrev.01/>
> As usual, I'll need a sponsor for this.
Is there anything I can do to make this patch more palatable?
More information about the core-libs-dev