RFR: 8214533 IBM-29626C is required for AIX default charset

Ichiroh Takiguchi takiguc at linux.vnet.ibm.com
Tue Jan 15 00:51:10 UTC 2019

Hello Alan.

Could you review the fix again ?

Bug:    https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/

I added IBM29626C charset as standard way.
Please give any suggestion and question.

Ichiroh Takiguchi
IBM Japan, Ltd.

On 2018-12-14 18:58, Ichiroh Takiguchi wrote:
> Hello Alan.
> I opened JDK-8215333 for Charset filtering issue [1].
> I cannot wait until JDK-8215333 is closed.
> Is it possible to put IBM-29626C charset with standard way ?
> [1] https://bugs.openjdk.java.net/browse/JDK-8215333
> Thanks,
> Ichiroh Takiguchi
> On 2018-12-10 21:21, Ichiroh Takiguchi wrote:
>> Hello Roger, Magnus and Alan.
>> I may need to put alias information into charsets file.
>> stdcs-xxx cannot handle this information...
>> Still AIX needs IBM-29626C charset for default encoding...
>> I appreciate if you give me further suggestions.
>> Thanks,
>> Ichiroh Takiguchi
>> On 2018-12-10 20:50, Alan Bateman wrote:
>>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
>>>> On 2018-12-07 21:20, Roger Riggs wrote:
>>>>> Hi,
>>>>> It is a nice feature that charsets are selected at build time using 
>>>>> the stdcs-xxx files.
>>>>> This change breaks that pattern and embeds os specific information 
>>>>> in more than one place.
>>>>> That does not seem like an improvement.  Is there any alternative?
>>>> I agree. Why is it not enough just to add it to stdcs-aix?
>>> My reading of the patch is that the "os" key is to avoid generating 
>>> it
>>> on non-AIX platforms, it will otherwise end up in jdk.charsets on
>>> non-AIX platforms. The general direction is welcome but I think
>>> further work and discussion will be needed to get the right set of
>>> changes to support filtering in the build. It can probably be
>>> separated from the changes to add IBM-29626C to AIX's java.base.
>>> -Alan

More information about the core-libs-dev mailing list