RFR 8211919: ZipDirectoryStream should provide a stream of paths that are relative to the directory

Alan Bateman Alan.Bateman at oracle.com
Tue Jan 15 09:07:39 UTC 2019

On 15/01/2019 00:13, Lance Andersen wrote:
> :
> Thank you Alan pointing out this example which the previous fix also 
> did not address.  I updated the change which addresses the above 
> example as well as the relative path
> Please see http://cr.openjdk.java.net/~lancea/8211919/webrev.02/index.html
Good, this looks right now. Are you planning to re-visit the 1-4 
comments at L426-433, just asking because point 4 is confusing as there 
isn't any code here that cares if the path starts with "./" or "."

I don't have time right now to study all the test cases in 
ZipFsDirectoryStreamTests so I only skimmed through it. I assume all the 
places that catch IOException and print the stack trace should be 
cleaned up to not catch the exception as you want the test to fail if it 
can't open the zip file. Also I assume "Zipfs" can be dropped from the 
name to be consistent with the existing test classes. A minor nit is 
that the really long lines will be annoying for future side-by-side 
reviews of changes to this test.


More information about the core-libs-dev mailing list