RFR 8211919: ZipDirectoryStream should provide a stream of paths that are relative to the directory

Lance Andersen lance.andersen at oracle.com
Tue Jan 15 21:27:02 UTC 2019

> On Jan 15, 2019, at 3:55 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 15/01/2019 18:59, Lance Andersen wrote:
>> OK thank you.  I made a ‘minor update to the comments and removed “4"
> Looks good. I also skimmed the update test and it looks okay too except setUp and tearDown where it still catches exception so the methods succeed when they fail. Maybe setUp could be changed to not catch the IOException. No need for a new webrev if you do that.
OK, I made that change. 

I also made 1 more change as I added back:

private static final Map<String, String> UNZIPFS_MAP = Map.of();

And all tests use that to open the jar files vs.ZIPFS_MAP which sets create=true so that the test do not create the jar if it does not already exist

http://cr.openjdk.java.net/~lancea/8211919/webrev.04/index.html has the update if you want to look at it.  I will push tomorrow

Thank you for the review!

> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list